diff --git a/src/routes/users/remove_friend.rs b/src/routes/users/remove_friend.rs index ebec7c6b9bc0c18439315ad75f84537fed011771..7d16277cf20e8b23917eab7bd71706804f9598d8 100644 --- a/src/routes/users/remove_friend.rs +++ b/src/routes/users/remove_friend.rs @@ -16,10 +16,6 @@ pub async fn req(user: User, target: Ref) -> Result<JsonValue> { let col = get_collection("users"); match get_relationship(&user, &target) { - RelationshipStatus::Blocked - | RelationshipStatus::BlockedOther - | RelationshipStatus::User - | RelationshipStatus::None => Err(Error::NoEffect), RelationshipStatus::Friend | RelationshipStatus::Outgoing | RelationshipStatus::Incoming => { @@ -79,6 +75,7 @@ pub async fn req(user: User, target: Ref) -> Result<JsonValue> { with: "user", }), } - } + }, + _ => Err(Error::NoEffect), } } diff --git a/src/routes/users/unblock_user.rs b/src/routes/users/unblock_user.rs index 2d7a13b6eee1b674ddd8b8fe53bbf7d52cf42dfc..711586848f73ec85f0dd762ecbef9f3f1709bc42 100644 --- a/src/routes/users/unblock_user.rs +++ b/src/routes/users/unblock_user.rs @@ -16,12 +16,6 @@ pub async fn req(user: User, target: Ref) -> Result<JsonValue> { let col = get_collection("users"); match get_relationship(&user, &target) { - RelationshipStatus::None - | RelationshipStatus::User - | RelationshipStatus::BlockedOther - | RelationshipStatus::Incoming - | RelationshipStatus::Outgoing - | RelationshipStatus::Friend => Err(Error::NoEffect), RelationshipStatus::Blocked => { match get_relationship(&target.fetch_user().await?, &user.as_ref()) { RelationshipStatus::Blocked => { @@ -114,6 +108,7 @@ pub async fn req(user: User, target: Ref) -> Result<JsonValue> { } _ => Err(Error::InternalError), } - } + }, + _ => Err(Error::NoEffect), } } diff --git a/src/util/variables.rs b/src/util/variables.rs index 282698402ed71f5bf45c7dbb5ee7433f871210b0..9e630ddf28ef90d3cb34b9f107f3c47ecf91502a 100644 --- a/src/util/variables.rs +++ b/src/util/variables.rs @@ -42,12 +42,8 @@ lazy_static! { pub fn preflight_checks() { if *USE_EMAIL == false { #[cfg(not(debug_assertions))] - { - if !env::var("REVOLT_UNSAFE_NO_EMAIL").map_or(false, |v| v == *"1") { - panic!( - "Not letting you run this in production, set REVOLT_UNSAFE_NO_EMAIL=1 to run." - ); - } + if !env::var("REVOLT_UNSAFE_NO_EMAIL").map_or(false, |v| v == *"1") { + panic!("Running in production without email is not recommended, set REVOLT_UNSAFE_NO_EMAIL=1 to override."); } #[cfg(debug_assertions)] @@ -56,10 +52,8 @@ pub fn preflight_checks() { if *USE_HCAPTCHA == false { #[cfg(not(debug_assertions))] - { - if !env::var("REVOLT_UNSAFE_NO_CAPTCHA").map_or(false, |v| v == *"1") { - panic!("Not letting you run this in production, set REVOLT_UNSAFE_NO_CAPTCHA=1 to run."); - } + if !env::var("REVOLT_UNSAFE_NO_CAPTCHA").map_or(false, |v| v == *"1") { + panic!("Running in production without CAPTCHA is not recommended, set REVOLT_UNSAFE_NO_CAPTCHA=1 to override."); } #[cfg(debug_assertions)]